Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify detectors a little more #1069

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Aug 3, 2020

This simplifies some common logic used by detectors a little more.

This should not change the logic, except for one small bug that this is fixing: we have some logic that prevents triggering a package.json scripts whose command includes netlify dev (to prevent infinite recursion). However, it was still possible to have netlify dev triggered by Netlify Dev when the script included one of the frameworks' preferredCommand. For example:

"scripts": {
  "build": "netlify dev && gatsby develop"
}

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Aug 3, 2020
@ehmicky ehmicky requested a review from erezrokah August 3, 2020 16:51
@ehmicky ehmicky self-assigned this Aug 3, 2020
@ehmicky ehmicky merged commit 3806af8 into master Aug 3, 2020
@ehmicky ehmicky deleted the chore/simplify-detectors-more branch August 3, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants